Add support for Ed25519 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…K::Ed25519). also added test cases.
also added test cases.
|
@mwander Thanks for this, I have refactored a few places to make the flow clearer, but looks good. Note: some consumers of this module may assume a RSA key object is returned by $signature->get_public_key(), and the new key type differs. For example, when querying the key size the class for Ed25519 keys doesn't have a size method, which can result in confusing results, or worst case a runtime error. This is something folks will need to consider when upgrading to this version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Ed25519 (closes #9).
Depends on Crypt::PK::Ed25519. Added test cases for signing and verification.
Most code has been added to PrivateKey.pm and PublicKey.pm. The ed25519_sha256.pm subclass is basically identical to rsa_sha256pm. I tried to retain existing logic wherever possible, but it was necessary to branch between 'rsa' and 'ed25519' code in serveral locations. Please review carefully.